fix: [#1489] Include Access-Control, Origin headers for cross-origin requests
#1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
force-pushed
the
fix/cors-origin-header
branch
from
020fa6c
to
b58c189
Compare
…r cross-origin requests Fixes capricorn86#1489
rexxars
force-pushed
the
fix/cors-origin-header
branch
from
b58c189
to
f6cc01f
Compare
rexxars
changed the title
Origin header for cross-origin requestsAccess-Control, Origin headers for cross-origin requests
capricorn86
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1489, cross-origin requests should always include the
Originheader. Additionally, CORS preflight requests should include additionalAccess-Control-*headers - these were not included because of the header filtering in the Request class.Fixes #1489